Skip to content

Commit

Permalink
Merge pull request #388 from wallrj/untyped-replicas
Browse files Browse the repository at this point in the history
Allow replicaCount to be set to int or string
  • Loading branch information
jetstack-bot authored Mar 1, 2024
2 parents 6e20fee + 79f6408 commit c1b51af
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 9 deletions.
30 changes: 26 additions & 4 deletions deploy/charts/approver-policy/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions deploy/charts/approver-policy/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@
},
"helm-values.crds.keep": {
"default": true,
"description": "This option makes it so that the \"helm.sh/resource-policy\": keep annotation is added to the CRD. This will prevent Helm from uninstalling the CRD when the Helm release is uninstalled. WARNING: when the CRDs are removed, all cert-manager custom resources\n(Certificates, Issuers, ...) will be removed too by the garbage collector.",
"description": "This option makes it so that the \"helm.sh/resource-policy\": keep annotation is added to the CRD. This will prevent Helm from uninstalling the CRD when the Helm release is uninstalled. WARNING: when the CRDs are removed, all cert-manager-approver-policy custom resources\n(CertificateRequestPolicy) will be removed too by the garbage collector.",
"type": "boolean"
},
"helm-values.dnsPolicy": {
Expand Down Expand Up @@ -424,8 +424,7 @@
},
"helm-values.replicaCount": {
"default": 1,
"description": "Number of replicas of approver-policy to run.",
"type": "number"
"description": "Number of replicas of approver-policy to run.\n\nFor example:\n Use integer to set a fixed number of replicas\nreplicaCount: 2\nUse null, if you want to omit the replicas field and use the Kubernetes default value.\nreplicaCount: null\nUse a string if you want to insert a variable for post-processing of the rendered template.\nreplicaCount: ${REPLICAS_OVERRIDE:=3}"
},
"helm-values.resources": {
"default": {},
Expand Down
16 changes: 14 additions & 2 deletions deploy/charts/approver-policy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,23 @@ crds:
# This option makes it so that the "helm.sh/resource-policy": keep
# annotation is added to the CRD. This will prevent Helm from uninstalling
# the CRD when the Helm release is uninstalled.
# WARNING: when the CRDs are removed, all cert-manager custom resources
# (Certificates, Issuers, ...) will be removed too by the garbage collector.
# WARNING: when the CRDs are removed, all cert-manager-approver-policy custom resources
# (CertificateRequestPolicy) will be removed too by the garbage collector.
keep: true

# Number of replicas of approver-policy to run.
#
# For example:
# Use integer to set a fixed number of replicas
# replicaCount: 2
#
# Use null, if you want to omit the replicas field and use the Kubernetes default value.
# replicaCount: null
#
# Use a string if you want to insert a variable for post-processing of the rendered template.
# replicaCount: ${REPLICAS_OVERRIDE:=3}
#
# +docs:type=number,string,null
replicaCount: 1

image:
Expand Down

0 comments on commit c1b51af

Please sign in to comment.