Format the issuers table #1383
Format the issuers table #1383
Conversation
jetstack-bot
added
dco-signoff: yes
wallrj
force-pushed
the
format-issuers-table
branch
from
9adc633 to
6685981
Compare
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wallrj
force-pushed
the
format-issuers-table
branch
2 times, most recently
from
748f3df to
35567e8
Compare
Signed-off-by: Richard Wall <richard.wall@venafi.com>
wallrj
force-pushed
the
format-issuers-table
branch
from
35567e8 to
70761de
Compare
Signed-off-by: Richard Wall <richard.wall@venafi.com>
| @@ -35,7 +37,7 @@ The following list contains all known cert-manager issuer integrations. | |||
| [//]: # (Configuration docs) | |||
|
|
|||
| [config:venafi-enhanced-issuer]: https://docs.venafi.cloud/vaas/k8s-components/t-vei-install/ | |||
| [config:acme-issuer]: ./acme.md | |||
| [config:acme-issuer]: ./acme/README.md | |||
There was a problem hiding this comment.
This broken link was picked up by the link checker.
Not sure why it hadn't highlighted it in earlier PRs.
| [ca:cfssl-issuer]: https://github.com/cloudflare/cfssl | ||
| [ca:freeipa-issuer]: https://www.freeipa.org | ||
| [ca:kms-issuer]: https://aws.amazon.com/kms/ | ||
| [ca:origin-ca-issuer]: https://developers.cloudflare.com/ssl/origin-configuration/origin-ca |
There was a problem hiding this comment.
I moved all the links to the CA documentation out of the table,
to make the table easier to read and for consistency with the other links in the table which are all aliased.
| | 🥉 | freeipa-issuer | [📄][config:freeipa-issuer] | [FreeIPA][ca:freeipa-issuer] | - | [❌][release:freeipa-issuer] | ✔️ | | ||
| | 🥉 | kms-issuer | [📄][config:kms-issuer] | [AWS KMS][ca:kms-issuer] | - | [❌][release:kms-issuer] | ✔️ | | ||
| | 🥉 | origin-ca-issuer | [📄][config:origin-ca-issuer] | [Cloudflare Origin CA][ca:origin-ca-issuer] | - | [❌][release:origin-ca-issuer] | ✔️ | | ||
|
|
There was a problem hiding this comment.
This and the earlier blank line between the markdown table and the surrounding html tags are what fix the table rendering in GitHub file preview.
There was a problem hiding this comment.
Thanks for the context. I have myself hit this issue of broken table due to an html tag too close to the bottom of the table multiple times.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
While reviewing #1382 I wanted to help the author move their new issuer to the right place in the table,
but the markdown table is currently unaligned and difficult to read in the GitHub preview,
so here I'm trying to fix that problem first.
vs