feat: Schema 4.0.0 enrichment #6273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import copy | ||
|
|
||
| modified_metadata = copy.deepcopy(self.sample_dataset_metadata) | ||
| modified_metadata.development_stage = [OntologyTermId("Test", "HsapDv:0000008")] | ||
| modified_metadata.tissue = [TissueOntologyTermId("Test", "UBERON:0002048", "cell culture")] | ||
| modified_metadata.tissue = [TissueOntologyTermId("Test", "UBERON:0002048")] |
MillenniumFalconMechanic
force-pushed
the
mim/6261-schema-4-enrichment
branch
from
3f3c197 to
7ae7202
Compare
Deployment Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6273 +/- ##
==========================================
+ Coverage 91.76% 91.78% +0.02%
==========================================
Files 175 175
Lines 14129 14167 +38
==========================================
+ Hits 12965 13003 +38
Misses 1164 1164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MillenniumFalconMechanic
changed the title
MillenniumFalconMechanic
force-pushed
the
mim/6261-schema-4-enrichment
branch
from
4b81bf2 to
34a13b4
Compare
backend/portal/api/enrichment.py
Outdated
| @@ -23,3 +35,17 @@ def enrich_dataset_with_ancestors(dataset, key, ontology_mapping): | |||
| unique_ancestors = list(OrderedDict.fromkeys(flattened_ancestors)) | |||
| if unique_ancestors: | |||
| dataset[f"{key}_ancestors"] = unique_ancestors | |||
|
|
|||
|
|
|||
| def generate_tagged_ontology_id(tissue): | |||
There was a problem hiding this comment.
nit: what do you think of renaming this function generate_tagged_tissue_ontology_id since its tissue-specific?
There was a problem hiding this comment.
Hey @nayib-jose-gloria, I have updated the function name!
MillenniumFalconMechanic
force-pushed
the
mim/6261-schema-4-enrichment
branch
from
44df942 to
dcc31c6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
MillenniumFalconMechanic
force-pushed
the
mim/6261-schema-4-enrichment
branch
from
dcc31c6 to
57d2671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
Changes
Testing steps
tissue_ancestors: