Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gh-actions): add explicit node installation and bump versions to 16 #6287

Merged
merged 8 commits into from
Nov 30, 2023
Merged

fix(gh-actions): add explicit node installation and bump versions to 16 #6287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a76eef4
Update push-tests.yml
seve Nov 30, 2023
1afd90b
Update deploy-happy-stack.yml
seve Nov 30, 2023
d5dd6bf
Update deploy-happy-stack.yml
seve Nov 30, 2023
1b69063
Update push-tests.yml
seve Nov 30, 2023
a18aa8f
Update push-tests.yml
seve Nov 30, 2023
496effb
no longer run in container, use v4 w/ nvmrc and caching
seve Nov 30, 2023
380de10
populate config file
seve Nov 30, 2023
83f3a27
typo
seve Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-happy-stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/setup-node@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and do we need to bump this version to 4 or is it not blocking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

with:
node-version: 15
node-version: "16.14.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this will be node-version-file: "frontend/.nvmrc" too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with an update to v4 as well, I'll do other edits in a separate PR to quickly unblock merges to main

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good thank you!

- name: Configure AWS Prod Credentials
uses: aws-actions/configure-aws-credentials@v2
if: github.event.deployment.environment == 'prod'
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/push-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,20 @@ jobs:
with:
fetch-depth: 2
- uses: actions/setup-python@v3

- name: check backend
uses: pre-commit/action@v3.0.0
- uses: actions/setup-node@v4
with:
node-version-file: "frontend/.nvmrc"
cache: "npm"
cache-dependency-path: "frontend/package-lock.json"
- name: check frontend
run: |
cp frontend/src/configs/local.js frontend/src/configs/configs.js
docker-compose run --no-deps --rm frontend make lint
cd frontend
seve marked this conversation as resolved.
Show resolved Hide resolved
npm ci
cp src/configs/local.js src/configs/configs.js
npm run lint
- uses: 8398a7/action-slack@v3
with:
status: ${{ job.status }}
Expand Down