Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gh-actions): add explicit node installation and bump versions to 16 #6287

Merged
merged 8 commits into from
Nov 30, 2023

Conversation

seve
Copy link
Contributor

@seve seve commented Nov 30, 2023

Reason for Change

  • #TICKET_NUMBER
  • If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5eb9c8b) 91.78% compared to head (83f3a27) 91.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6287   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files         175      175           
  Lines       14167    14167           
=======================================
  Hits        13003    13003           
  Misses       1164     1164           
Flag Coverage Δ
unittests 91.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @seve ! Not sure why it suddenly started failing the lint GHA 🤔

.github/workflows/push-tests.yml Show resolved Hide resolved
@tihuan
Copy link
Contributor

tihuan commented Nov 30, 2023

@seve can you give the team a headsup that you're fixing the lint GHA error, so people know it's being taken care of? Thank you!

@seve seve enabled auto-merge (squash) November 30, 2023 22:11
@@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/setup-node@v2
with:
node-version: 15
node-version: "16.14.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this will be node-version-file: "frontend/.nvmrc" too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with an update to v4 as well, I'll do other edits in a separate PR to quickly unblock merges to main

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good thank you!

@@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/setup-node@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and do we need to bump this version to 4 or is it not blocking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@seve seve requested a review from tihuan November 30, 2023 22:24
@seve seve disabled auto-merge November 30, 2023 22:35
@seve seve merged commit 9449220 into main Nov 30, 2023
38 checks passed
@seve seve deleted the seve/fix-node-actions branch November 30, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants