-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gh-actions): add explicit node installation and bump versions to 16 #6287
Conversation
Deployment Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6287 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 175 175
Lines 14167 14167
=======================================
Hits 13003 13003
Misses 1164 1164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, @seve ! Not sure why it suddenly started failing the lint GHA 🤔
@seve can you give the team a headsup that you're fixing the lint GHA error, so people know it's being taken care of? Thank you! |
@@ -18,7 +18,7 @@ jobs: | |||
steps: | |||
- uses: actions/setup-node@v2 | |||
with: | |||
node-version: 15 | |||
node-version: "16.14.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this will be node-version-file: "frontend/.nvmrc"
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with an update to v4 as well, I'll do other edits in a separate PR to quickly unblock merges to main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good thank you!
@@ -18,7 +18,7 @@ jobs: | |||
steps: | |||
- uses: actions/setup-node@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and do we need to bump this version to 4 or is it not blocking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks!
Reason for Change
Changes
Testing steps
Checklist 🛎️
Notes for Reviewer