fix(gui): reduce AI settings modal full-reload usage

[chhoumann]

Reduce unnecessary full modal reloads in AI settings flows by rendering high-churn sections in place.

This follows the FSM migration in #1132 and queue hardening in #1133. The remaining UX churn in these modals was mostly caused by full reloads for interactions that only affect a small subsection of UI.

What changed:

• AIAssistantCommandSettingsModal
  • show/hide advanced settings now re-renders only the advanced section container (no full modal reload)
  • name edit now updates header text directly (no full modal reload)
  • model dropdown now refreshes token count text directly (no full modal reload)
• InfiniteAIAssistantCommandSettingsModal
  • show/hide advanced settings now re-renders only the advanced section container (no full modal reload)
  • name edit now updates header text directly (no full modal reload)
• Updated the living exec plan with this phase-2 decision/progress/evidence

Why:

• Advanced settings toggle is a frequent interaction and does not require rebuilding unrelated controls.
• In-place updates reduce UI churn and make the modal feel stable even before fallback restoration logic is needed.

Validation:

• bun run test
• bun run build-with-lint
• Obsidian CLI probe in dev vault:
  • open quickadd:testQuickAdd
  • force modal scrollable height
  • toggle Show advanced settings
  • observed before/after scrollTop remain 220 and active element remain TEXTAREA
  • dev:errors reported no runtime errors

Refs #1130

---

Summary by CodeRabbit

Bug Fixes

• AI command settings modals now update more efficiently—advanced settings, model changes, and name edits no longer trigger unnecessary full reloads, improving responsiveness.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
quickadd	Ready	Preview	Mar 5, 2026 6:57am

[coderabbitai]

📝 Walkthrough

Walkthrough

Two AI command settings modal components are refactored to eliminate full modal reloads for show advanced settings toggles, name edits, and model changes. Instead, targeted in-place UI updates are performed. A planning document is updated to reflect this phase-2 approach with supporting rationale and observations.

Changes

Cohort / File(s)	Summary
Planning & Documentation plans/issue-1130-fsm-modal-reload.md	Phase-2 plan added documenting in-place advanced settings rendering instead of full reloads; Surprises & Discoveries, Decision Log, and Outcomes sections updated with rationale and CLI evidence; Revision Note reflects phase-2 partial migration.
Modal UI Components src/gui/MacroGUIs/AIAssistantCommandSettingsModal.ts, src/gui/MacroGUIs/AIAssistantInfiniteCommandSettingsModal.ts	Two new fields added (advancedSettingsContainer, refreshTokenCountText) to manage targeted updates. Show Advanced Settings toggle now invokes renderAdvancedSettingsSection() instead of reloading. Name edits update header text in-place. Model changes trigger token-count refresh without full reload. New renderAdvancedSettingsSection() method handles advanced settings rendering directly.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(gui): preserve modal edit position during settings reload #1132: Introduces ModalReloadController to coordinate full reloads across modals, complementing the main PR's targeted-update optimization approach for the same modal classes.

Poem

🐰 No more full reloads, just targeted care,
Advanced settings rendered right there,
Names update smoothly, models refresh with grace,
UI bounces less in this speedier space! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the primary change: reducing unnecessary full-modal reloads in AI settings modals by implementing targeted, in-place UI updates instead.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fsm-phase2-reduce-ai-modal-reloads

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cloudflare-workers-and-pages]

Deploying quickadd with    Cloudflare Pages

Latest commit:	8cfbf43
Status:	✅  Deploy successful!
Preview URL:	https://aea1e1d3.quickadd.pages.dev
Branch Preview URL:	https://fsm-phase2-reduce-ai-modal-r.quickadd.pages.dev

View logs

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

[coderabbitai]

🧹 Nitpick comments (1)

src/gui/MacroGUIs/AIAssistantCommandSettingsModal.ts (1)

257-270: Consider extracting advanced-section rendering to a shared helper.

This block closely mirrors the implementation in src/gui/MacroGUIs/AIAssistantInfiniteCommandSettingsModal.ts (Line 214-227). Centralizing it would reduce maintenance drift across the two modals.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/gui/MacroGUIs/AIAssistantCommandSettingsModal.ts` around lines 257 - 270,
The renderAdvancedSettingsSection implementations in
AIAssistantCommandSettingsModal.renderAdvancedSettingsSection and
AIAssistantInfiniteCommandSettingsModal.renderAdvancedSettingsSection are
duplicated; extract the common logic into a single shared helper (either a
utility function like renderCommonAdvancedSettings(container, settings) or a
protected method on a shared base class such as
AIAssistantBaseSettingsModal.renderAdvancedSettingsSectionCommon) that performs
the container.empty(), showAdvancedSettings check, ensures
settings.modelParameters, and calls
addTemperatureSetting/addTopPSetting/addFrequencyPenaltySetting/addPresencePenaltySetting
on the provided container; then replace both original methods to call that
shared helper to remove duplication and keep references to the existing methods
(addTemperatureSetting, addTopPSetting, addFrequencyPenaltySetting,
addPresencePenaltySetting) intact.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/gui/MacroGUIs/AIAssistantCommandSettingsModal.ts`:
- Around line 257-270: The renderAdvancedSettingsSection implementations in
AIAssistantCommandSettingsModal.renderAdvancedSettingsSection and
AIAssistantInfiniteCommandSettingsModal.renderAdvancedSettingsSection are
duplicated; extract the common logic into a single shared helper (either a
utility function like renderCommonAdvancedSettings(container, settings) or a
protected method on a shared base class such as
AIAssistantBaseSettingsModal.renderAdvancedSettingsSectionCommon) that performs
the container.empty(), showAdvancedSettings check, ensures
settings.modelParameters, and calls
addTemperatureSetting/addTopPSetting/addFrequencyPenaltySetting/addPresencePenaltySetting
on the provided container; then replace both original methods to call that
shared helper to remove duplication and keep references to the existing methods
(addTemperatureSetting, addTopPSetting, addFrequencyPenaltySetting,
addPresencePenaltySetting) intact.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07dd4105-d409-4c0f-b48d-359d7634a843

📥 Commits

Reviewing files that changed from the base of the PR and between 9373144 and 8cfbf43.

📒 Files selected for processing (3)

• plans/issue-1130-fsm-modal-reload.md
• src/gui/MacroGUIs/AIAssistantCommandSettingsModal.ts
• src/gui/MacroGUIs/AIAssistantInfiniteCommandSettingsModal.ts

[github-actions]

🎉 This PR is included in version 2.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀