Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymbolTable: Gracefully handle current CHECK-fail #2029

Merged
merged 1 commit into from
Oct 21, 2023
Merged

SymbolTable: Gracefully handle current CHECK-fail #2029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion verilog/analysis/symbol_table.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2017,7 +2017,12 @@ static void ResolveReferenceComponentNode(
switch (component.ref_type) {
case ReferenceType::kUnqualified: {
// root node: lookup this symbol from its context upward
CHECK(node->Parent() == nullptr);
if (node->Parent() != nullptr) {
// TODO(hzeller): Is this a situation that should never happen thus
// be dealt with further up-stream ? (changed from a CHECK()).
LOG(WARNING) << *node << ": Parent exists " << *node->Parent() << "\n";
return;
}
ResolveUnqualifiedName(&component, context, diagnostics);
break;
}
Expand Down
Loading