BasicTextField2 + TextFieldState fix for this issue #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops the requirement to use Immediate Clock to make this all work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This video recording https://github.com/chris-horner/Compose-Input/assets/44558292/0de5bb92-2de4-428d-a23e-44d99bf5a346 shows how the behavior now no longer is buggy using BasicTextField2 + TextFieldState.
The important bit here is that the switch to use Immediate clock no longer had to be flipped to make it all work
Some extra code was added in there to show that updating other states and handling events which make molecule emit again does not seem to break the text field in any way.
Making this PR to reference in cashapp/molecule#63, the discussion can continue there.