-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project fund sources to reflect reorganization #1486
Open
mddilley
wants to merge
2
commits into
main
Choose a base branch
from
mike/19853_reorg_funding_sources
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
moped-database/migrations/1730931541884_reorg_funding_sources/down.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
-- Updating funding sources will be up only. If we need to revert, we will need do it manually or | ||
-- update with a future migration. | ||
SELECT 0; |
33 changes: 33 additions & 0 deletions
33
moped-database/migrations/1730931541884_reorg_funding_sources/up.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
-- Insert new funding source and soft-delete existing funding sources that are merging into the new one | ||
INSERT INTO "public"."moped_fund_sources" ("funding_source_name") VALUES | ||
('Austin Transportation and Public Works'); | ||
|
||
UPDATE moped_fund_sources SET is_deleted = true WHERE funding_source_name IN ('Austin Transportation', 'Public Works'); | ||
|
||
-- Find existing project funding records that are associated with the funding sources that are merging | ||
-- and update them to the new funding source called Austin Transportation and Public Works | ||
WITH funding_source_todos AS ( | ||
SELECT funding_source_id AS ids | ||
FROM | ||
moped_fund_sources | ||
WHERE | ||
funding_source_name IN ( | ||
'Austin Transportation', | ||
'Public Works' | ||
) | ||
), | ||
|
||
new_funding_source_row AS ( | ||
SELECT funding_source_id AS id | ||
FROM | ||
moped_fund_sources | ||
WHERE | ||
funding_source_name = 'Austin Transportation and Public Works' | ||
) | ||
|
||
UPDATE | ||
moped_proj_funding | ||
SET | ||
funding_source_id = (SELECT id FROM new_funding_source_row) | ||
WHERE | ||
funding_source_id IN (SELECT ids FROM funding_source_todos); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely convinced these CTEs make this more readable since there are still sub-queries in the UPDATE statement below. Open to updating if anyone feels strongly about it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like them! i wish i could bookmark this migration for the next time we need to do this kind of operation.
i suppose i can bookmark it... 🤔