Conditional DataStore Tab in Resource Edit #190
Conversation
- Added helper for valid xloader formats. - Added condition to display the DataStore tab in Resource Edit.
|
Looks good to me, but I'm not a maintainer here. Do you want to open a pull request to the qld-gov-au fork, ideally the develop branch? Actually, while you're working on this, do you think you could add a datastore tab link to the resource view page when appropriately authorised? Would be nice to be able to go there in one click. |
…tore link in resource read; - Added condition for `datastore_rw_resource_url_types`. - Added DataStore action link to resource read if perms are correct.
…, added new helper; - Added the conditional DataStore action link to more templates. - Added another new helper to handle possible non-existant core helper.
|
DataStore action link now added to more templates as to feedback here: ckan/ckan#7647 (review) |
|
Don't get me wrong, this is a promising feature, I just want to help ensure it's at its best. |
- Combined helpers and conditions into one helper. - Moved `XLoaderFormats` class to utils script to prevent circular imports.
|
Comments addressed from qld-gov-au#49 |
|
@ThrawnCA this PR could just get marked for a release alongside the next CKAN release. As the templates are made for the latest ckan, users can just override them if they need to for older releases. |
You could, but then no one can do any testing of it now. I intend to deploy this on data.qld.gov.au, but we're still on 2.9, currently working on the 2.10 upgrade. If even 2.10 can't use it... it'll be potentially a long time before we can give any feedback. |
|
In extensions it's desirable to be able to support a number of ckan releases. The template blocks won't be visible in current releases but do they prevent people from using the feature? |
We've deployed it on dev.data.qld.gov.au and it does nothing, no change. It doesn't have any errors, the new blocks are just ignored. |
|
These pieces of templates were not in Xloader at all. These templates and blocks are completely new in this PR. So it does not affect the functionality of the extension at all. The only template the existed before was So all of the newly added templates could be considered "for the future" |
|
Why not just add the new link to the |
# Conflicts: # ckanext/xloader/plugin.py ### RESOLVED.
- Added old template blocks for version 2.10 and less. - Added falsy check on url_type in template helper method.
- Added in line comments. - Used shorthand syntax.
feat(templates): conditional DataStore tab;