Conditional DataStore Tab in Resource Edit #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added helper for valid xloader formats. - Added condition to display the DataStore tab in Resource Edit.
…tore link in resource read; - Added condition for `datastore_rw_resource_url_types`. - Added DataStore action link to resource read if perms are correct.
ThrawnCA
reviewed
Jun 14, 2023
ThrawnCA
requested changes
Jun 14, 2023
…, added new helper; - Added the conditional DataStore action link to more templates. - Added another new helper to handle possible non-existant core helper.
|
DataStore action link now added to more templates as to feedback here: ckan/ckan#7647 (review) |
ThrawnCA
reviewed
Jun 15, 2023
- Combined helpers and conditions into one helper. - Moved `XLoaderFormats` class to utils script to prevent circular imports.
ThrawnCA
approved these changes
Jun 16, 2023
|
Looking good! Just need to resolve the merge conflict. It looks like we've removed an unused full-text import, while you've added the utils import on an adjacent line, and so Git is confused about what to do. |
|
Remade PR in divergent branch: #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(templates): conditional DataStore tab;
Added helper for valid xloader formats.
Added condition to display the DataStore tab in Resource Edit.
See ckan#190 for more details/discussion.