Fix aws broker #16
Merged
Fix aws broker #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdboyd
reviewed
Sep 17, 2024
| DB_TYPE: postgresql | ||
| services: | ||
| - rds-test-pg | ||
| - name: aws-rds-smoke-test-suite-oracle |
There was a problem hiding this comment.
We still have smoke tests for Oracle. Are we sure that we can remove this?
https://github.com/cloud-gov/aws-broker/blob/main/ci/pipeline.yml#L413
There was a problem hiding this comment.
Yes, that wasn't being used as it doesn't work. The DB_TYPE is overridden for each test. The Oracle tests are still happening with this change.
markdboyd
reviewed
Sep 17, 2024
Comment on lines
-12
to
-13
| services: | ||
| - rds-test-pg |
There was a problem hiding this comment.
How do we know this is valid to remove?
There was a problem hiding this comment.
It never was used. The services are created by each of the tests with a specific name to indicate which test created the service. I've been testing without it this whole time. I will test again once this is merged.
markdboyd
approved these changes
Sep 17, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
security considerations
None