Skip to content

Fix aws broker #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Fix aws broker #16

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a439da2
fixing mismatch for DB_TYPE in aws-broker, and removing Oracle test app
rcgottlieb Sep 3, 2024
9bacbc1
commenting out extraneous service
rcgottlieb Sep 4, 2024
15ed566
changing db var name to rds to allow for more than just postgres
rcgottlieb Sep 10, 2024
c72f0c3
fix for acceptance tests
rcgottlieb Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions databases/aws-rds/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,5 @@ applications:
GOPACKAGENAME: aws-rds
CGO_CFLAGS: -Isrc/github.com/cloud-gov/databases/aws-rds/include
LD_LIBRARY_PATH: "/home/vcap/app/include/oracle:$LD_LIBRARY_PATH"
SERVICE_NAME: ((pg-service))
DB_TYPE: postgresql
services:
- rds-test-pg
Comment on lines -12 to -13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know this is valid to remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It never was used. The services are created by each of the tests with a specific name to indicate which test created the service. I've been testing without it this whole time. I will test again once this is merged.

- name: aws-rds-smoke-test-suite-oracle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have smoke tests for Oracle. Are we sure that we can remove this?

https://github.com/cloud-gov/aws-broker/blob/main/ci/pipeline.yml#L413

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that wasn't being used as it doesn't work. The DB_TYPE is overridden for each test. The Oracle tests are still happening with this change.

buildpacks:
- go_buildpack
env:
GOVERSION: go1.22
GOPACKAGENAME: aws-rds
CGO_CFLAGS: -Isrc/github.com/cloud-gov/databases/aws-rds/include
LD_LIBRARY_PATH: "/home/vcap/app/include/oracle:$LD_LIBRARY_PATH"
SERVICE_NAME: ((oracle-service))
DB_TYPE: oracle
services:
- rds-test-oracle
SERVICE_NAME: ((rds-service))
DB_TYPE: postgresql # valid types are postgresql, mysql and oracle