[gs] Add missing gcs-oauth2-boto-plugin package for non-raz scenarios #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harshg999
requested review from
wing2fly,
amitsrivastava,
JohanAhlen,
bjornalm,
ranade1,
athithyaaselvam and
agl29
Harshg999
changed the title
amitsrivastava
approved these changes
Nov 1, 2023
agl29
reviewed
Nov 2, 2023
| @@ -59,7 +60,7 @@ pytidylib==0.3.2 | |||
| pytz==2021.3 | |||
| PyJWT==2.4.0 | |||
| requests-kerberos==0.12.0 | |||
| rsa==4.7 | |||
| rsa==4.7.2 | |||
There was a problem hiding this comment.
Is there a specific reason for using this specific version? Can't we upgrade it to the latest version, 4.9?
There was a problem hiding this comment.
The package has dependency on rsa=4.7.2 so I changed to that version only.
https://github.com/GoogleCloudPlatform/gcs-oauth2-boto-plugin/blob/b749ea3424c26145277dc3c3987220891324023f/setup.py#L32
Also since this looks like an important package, I didn't want to bump it up higher due to regression concerns.
wing2fly
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
@Harshg999
Are we using boto to integrate with GS, so we have this plugin lib?
Please add one or two lines in description to explain.
athithyaaselvam
pushed a commit
that referenced
this pull request
Jun 10, 2024
…az scenarios (#3523) - Also add correct version for rsa==4.7.2 which is a dependency for gcs-oauth2-boto-plugin (cherry picked from commit 55883fb) (cherry picked from commit bf2e95e) Change-Id: Ifd3d1db1dde611ba7a2c042e330f1b6e94932047 (cherry picked from commit a6e6de678a749610b9406ed1e941a802206452a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?