Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gs] Add missing gcs-oauth2-boto-plugin package for non-raz scenarios #3523

Merged
merged 3 commits into from
Dec 18, 2023
Merged

[gs] Add missing gcs-oauth2-boto-plugin package for non-raz scenarios #3523

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7df6c4a
[gs] Add missing gcs-oauth2-boto-plugin package for non-RAZ scenarios
Harshg999 Nov 1, 2023
4b72f08
[gs] Add correct version for rsa==4.7.2
Harshg999 Nov 2, 2023
c647ab1
Merge branch 'master' into add-gs-package
Harshg999 Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion desktop/core/base_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ djangomako==1.3.2
djangorestframework-simplejwt==5.2.0
djangorestframework==3.12.2
future==0.18.3
gcs-oauth2-boto-plugin==3.0
greenlet==2.0.2
gunicorn==19.9.0
ipython==8.12.2 # Python >= 3.8
Expand Down Expand Up @@ -59,7 +60,7 @@ pytidylib==0.3.2
pytz==2021.3
PyJWT==2.4.0
requests-kerberos==0.12.0
rsa==4.7
rsa==4.7.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason for using this specific version? Can't we upgrade it to the latest version, 4.9?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package has dependency on rsa=4.7.2 so I changed to that version only.
https://github.com/GoogleCloudPlatform/gcs-oauth2-boto-plugin/blob/b749ea3424c26145277dc3c3987220891324023f/setup.py#L32

Also since this looks like an important package, I didn't want to bump it up higher due to regression concerns.

sasl==0.3.1 # Move to https://pypi.org/project/sasl3/ ?
slack-sdk==3.2.0
SQLAlchemy==1.3.8
Expand Down
Loading