fix(graphql): prevent GraphQL injection in fetchTypeDetails#321
Open
spidershield-contrib wants to merge 1 commit intocloudflare:mainfrom
Open
fix(graphql): prevent GraphQL injection in fetchTypeDetails#321spidershield-contrib wants to merge 1 commit intocloudflare:mainfrom
spidershield-contrib wants to merge 1 commit intocloudflare:mainfrom
Conversation
The typeName parameter was interpolated directly into a GraphQL query string via template literal, allowing injection of arbitrary GraphQL syntax through crafted type names (e.g., a name containing `")`). Use a GraphQL variable ($typeName) instead of string interpolation so the value is properly handled by the GraphQL engine as data, not as part of the query structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #320
Uses a GraphQL variable (
$typeName) instead of string interpolation to pass the type name to__type()infetchTypeDetails(). This prevents injection of arbitrary GraphQL syntax through crafted type names.Changes
apps/graphql/src/tools/graphql.tools.ts"${typeName}"interpolation with$typeNamevariable; pass variable via request bodyBefore / After
Before (vulnerable):
After (safe):
Test Plan
npx tsc --noEmit -p apps/graphql/tsconfig.json— zero errors