Skip to content

fix(graphql): prevent GraphQL injection in fetchTypeDetails #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spidershield-contrib wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(graphql): prevent GraphQL injection in fetchTypeDetails #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions apps/graphql/src/tools/graphql.tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ async function fetchSchemaOverview(apiToken: string): Promise<SchemaOverviewResp
*/
async function fetchTypeDetails(typeName: string, apiToken: string): Promise<TypeDetailsResponse> {
const typeDetailsQuery = `
query TypeDetails {
__type(name: "${typeName}") {
query TypeDetails($typeName: String!) {
__type(name: $typeName) {
name
kind
description
Expand Down Expand Up @@ -174,8 +174,30 @@ async function fetchTypeDetails(typeName: string, apiToken: string): Promise<Typ
}
`

const response = await executeGraphQLRequest<TypeDetailsResponse>(typeDetailsQuery, apiToken)
return response
const response = await fetch(CLOUDFLARE_GRAPHQL_ENDPOINT, {
method: 'POST',
headers: {
'Content-Type': 'application/json',
Authorization: `Bearer ${apiToken}`,
},
body: JSON.stringify({
query: typeDetailsQuery,
variables: { typeName },
}),
})

if (!response.ok) {
throw new Error(`Failed to execute GraphQL request: ${response.statusText}`)
}

const data = graphQLResponseSchema.parse(await response.json())

if (data && data.errors && Array.isArray(data.errors) && data.errors.length > 0) {
const errorMessages = data.errors.map((e: { message: string }) => e.message).join(', ')
console.warn(`GraphQL errors: ${errorMessages}`)
}

return data as unknown as TypeDetailsResponse
}

/**
Expand Down