Temporarily move integration tests to the push event #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We will change this commit in the near future to ensure that the integration tests run again on pull requests Signed-off-by: João Pereira <joaod@vmware.com> Co-Authored-by: Greg Weresch <greg.weresch@broadcom.com>
|
LGTM |
a-b
reviewed
Aug 2, 2024
| @@ -24,6 +24,11 @@ on: | |||
| - "Tests" | |||
| types: | |||
| - completed | |||
| push: | |||
| branches: | |||
There was a problem hiding this comment.
question: Is it possible to run integration tests only if the unit tests pass successfully?
There was a problem hiding this comment.
At this point we decided only to run integration tests on push (after the pr is merged) This is a little bit strange but in reality, this was what was happening with the bug we found yesterday.
This solution is a stop-gap solution and I hope we can start the work to re-add the integration tests into the PR workflow at the beginning of next week.
a-b
approved these changes
Aug 2, 2024
joaopapereira
added a commit
to joaopapereira/cf-cli
that referenced
this pull request
Aug 5, 2024
…undry#3075)" This reverts commit f59c02a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Temporarily move integration tests to the push event