Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily move integration tests to the push event #3075

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Temporarily move integration tests to the push event #3075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/tests-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ on:
- "Tests"
types:
- completed
push:
branches:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Is it possible to run integration tests only if the unit tests pass successfully?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we decided only to run integration tests on push (after the pr is merged) This is a little bit strange but in reality, this was what was happening with the bug we found yesterday.
This solution is a stop-gap solution and I hope we can start the work to re-add the integration tests into the PR workflow at the beginning of next week.

- main
- v8
- v7

jobs:
run-integration-tests-cf-env:
Expand Down Expand Up @@ -74,4 +79,4 @@ jobs:
run-with-client-creds: false
os: ubuntu-latest
name: cats
secrets: inherit
secrets: inherit
10 changes: 0 additions & 10 deletions .github/workflows/tests-unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,4 @@ jobs:
Get-Item Makefile
make units



integration:
needs:
- units
- units-windows
name: Integration tests
if: ${{ github.event != 'workflow_dispatch' }}
uses: ./.github/workflows/tests-integration.yml
secrets: inherit
# vim: set sw=2 ts=2 sts=2 et tw=78 foldlevel=2 fdm=indent nospell:
Loading