Option to send websockets upstream using HTTP/1.1 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46bit
changed the title
|
Closing in favor of #263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gorouter recently added support for HTTP/2. However it turns out to be broken for HTTP/2 Websockets (RFC 8441): cloudfoundry/routing-release#230. It can't immediately be fixed because the bug arises from a problem in Go's
net/http: golang/go#32763.This PR implements a suggestion by @Gerg in #259: forward Websocket traffic to Gorouter over HTTP/1.1, even if HTTP2 is enabled.
Downside of this approach is that we're duplicating a lot of config between the two
backendblocks. To stop them drifting from each other, I've added a test that their config matches. If anyone only changes one of the blocks then the tests will fail, pushing them to change the other block as well.