Add property to force backend websocket connections to use HTTP/1.1 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterellisjones
force-pushed
the
send-websockets-upstream-using-http1.1
branch
4 times, most recently
from
9b25197
to
e65dc0e
Compare
peterellisjones
changed the title
peterellisjones
changed the title
peterellisjones
force-pushed
the
send-websockets-upstream-using-http1.1
branch
from
bb7a5e4
to
400a1e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #261
Gorouter recently added support for HTTP/2. However it turns out to be broken for HTTP/2 Websockets (RFC 8441): cloudfoundry/routing-release#230. It can't immediately be fixed because the bug arises from a problem in Go's net/http: golang/go#32763.
This PR implements a suggestion by @Gerg in #259: forward Websocket traffic to Gorouter over HTTP/1.1, even if HTTP2 is enabled, when the new property
disable_backend_http2_websocketsis set totrue(defaultfalse)