Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full-text search DDLs #111

Merged

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Sep 21, 2024

This PR includes CREATE SEARCH INDEX, ALTER SEARCH INDEX, and DROP SEARCH INDEX statements.

Depends on helper functions in #101, so this branch includes implementation of CREATE PROPERTY GRAPH, and DROP PROPERTY GRAPH.
It needs rebase after merge that.

rebased.

  • CREATE SEARCH INDEX

  • ALTER SEARCH INDEX

  • DROP SEARCH INDEX

  • Ensure CREATE TABLE in full-text search examples can be parsed.

    CREATE TABLE Albums (
      AlbumId STRING(MAX) NOT NULL,
      SingerId INT64 NOT NULL,
      ReleaseTimestamp INT64 NOT NULL,
      AlbumTitle STRING(MAX),
      Rating FLOAT64,
      AlbumTitle_Tokens TOKENLIST AS (TOKENIZE_FULLTEXT(AlbumTitle)) HIDDEN,
      Rating_Tokens TOKENLIST AS (TOKENIZE_NUMBER(Rating)) HIDDEN
    ) PRIMARY KEY(AlbumId);
  • Implement ast.SearchIndexOptions on ast.GenericOptions Generalize OPTIONS behavior #137

  • Add Pos.Add() and firstValid to refactor End() 2127e0e

fix #108

depends on #120

@apstndb apstndb force-pushed the feature/search-index-ddls branch from 13b3825 to d3d9be2 Compare October 15, 2024 14:15
@apstndb apstndb marked this pull request as ready for review October 16, 2024 06:01
Copy link
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor suggestions and give a major issue. Please check it.

@apstndb
Copy link
Contributor Author

apstndb commented Oct 19, 2024

This PR still depends on #142, so I turn this PR as draft.

@apstndb apstndb marked this pull request as draft October 19, 2024 15:52
@apstndb apstndb marked this pull request as ready for review October 20, 2024 06:28
@apstndb
Copy link
Contributor Author

apstndb commented Oct 20, 2024

Merge OPTIONS and conflict is resolved. Re-opened.

@apstndb
Copy link
Contributor Author

apstndb commented Oct 22, 2024

Merged to fix conflicts.

@apstndb apstndb requested a review from makenowjust October 22, 2024 15:26
@apstndb apstndb requested a review from makenowjust October 24, 2024 07:38
Copy link
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@makenowjust makenowjust merged commit 0b37cb6 into cloudspannerecosystem:main Oct 25, 2024
2 checks passed
@apstndb apstndb deleted the feature/search-index-ddls branch October 25, 2024 05:44
@apstndb apstndb mentioned this pull request Nov 11, 2024
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CREATE/ALTER/DROP SEARCH INDEX
2 participants