-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full-text search DDLs #111
Support full-text search DDLs #111
Conversation
13b3825
to
d3d9be2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor suggestions and give a major issue. Please check it.
This PR still depends on #142, so I turn this PR as draft. |
Merge OPTIONS and conflict is resolved. Re-opened. |
Merged to fix conflicts. |
Co-authored-by: Hiroya Fujinami <make.just.on@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR includes
CREATE SEARCH INDEX
,ALTER SEARCH INDEX
, andDROP SEARCH INDEX
statements.Depends on helper functions in #101, so this branch includes implementation ofCREATE PROPERTY GRAPH
, andDROP PROPERTY GRAPH
.It needs rebase after merge that.
rebased.
CREATE SEARCH INDEX
ALTER SEARCH INDEX
DROP SEARCH INDEX
Ensure
CREATE TABLE
in full-text search examples can be parsed.STORED
optional in generated columnsHIDDEN
columnImplementast.SearchIndexOptions
onast.GenericOptions
Generalize OPTIONS behavior #137Add
Pos.Add()
andfirstValid
to refactorEnd()
2127e0efix #108
depends on #120