Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zh translate for the 2024 sustainable week event page #427

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

SamYuan1990
Copy link
Contributor

@SamYuan1990 SamYuan1990 commented May 31, 2024

get it ready as call for volunteers and sponsors for 2024 sustainable week in China.

Copy link

netlify bot commented May 31, 2024

Deploy Preview for tag-env-sustainability ready!

Name Link
🔨 Latest commit 7217dea
🔍 Latest deploy log https://app.netlify.com/sites/tag-env-sustainability/deploys/66936e4a3fa5d2000884fb3c
😎 Deploy Preview https://deploy-preview-427--tag-env-sustainability.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SamYuan1990 SamYuan1990 changed the title add zh translate for the event page [place holder, don't merge]add zh translate for the event page May 31, 2024
@SamYuan1990 SamYuan1990 marked this pull request as draft May 31, 2024 15:14
Signed-off-by: Sam Yuan <yy19902439@126.com>
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 changed the title [place holder, don't merge]add zh translate for the event page add zh translate for the 2024 sustainable week event page Jul 14, 2024
@SamYuan1990 SamYuan1990 marked this pull request as ready for review July 14, 2024 06:21
Copy link
Contributor

@guidemetothemoon guidemetothemoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @SamYuan1990 ! Should anyone else with the knowledge of the language review these changes?
I'll keep it open until your feedback.

Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leonardpahlke leonardpahlke merged commit 02edd11 into cncf:main Jul 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants