Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆ Update Debain version of base image #6574

Merged
merged 2 commits into from
Dec 12, 2023
Merged

⬆ Update Debain version of base image #6574

merged 2 commits into from
Dec 12, 2023

Conversation

bdsoha
Copy link
Contributor

@bdsoha bdsoha commented Dec 10, 2023

Fixes #6540

@bdsoha bdsoha requested a review from a team as a code owner December 10, 2023 06:17
code-asher
code-asher reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The update looks good to me. Are we sure we will not cause regressions with --no-install-recommends? I am wondering if software that used to be installed will now be missing and we will get issue reports about it.

@bdsoha
Copy link
Contributor Author

bdsoha commented Dec 12, 2023

Thank you! The update looks good to me. Are we sure we will not cause regressions with --no-install-recommends? I am wondering if software that used to be installed will now be missing and we will get issue reports about it.

I will prepare a separate PR with the --no-install-recommends to compare installed packages with and without the flag.

@bdsoha bdsoha requested a review from code-asher December 12, 2023 19:47
code-asher
code-asher approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will prepare a separate PR with the --no-install-recommends to compare installed packages with and without the flag.

Perfect, thank you!

@code-asher code-asher merged commit 7649b6e into coder:main Dec 12, 2023
9 checks passed
@bdsoha bdsoha deleted the feature/update-debian branch December 13, 2023 05:40
This was referenced Dec 13, 2023
Merged
Merged
yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
@bdsoha @yiliang114
Update base release image to Debian:12 (coder#6574)
0ce52ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: Update base image to use Debians's bookworm release
2 participants
@bdsoha @code-asher