Skip to content

🤖 fix: document vendor stamp-file handling#22

Merged
ThomasK33 merged 3 commits intomainfrom
vendor-config-401t
Feb 10, 2026
Merged

🤖 fix: document vendor stamp-file handling#22
ThomasK33 merged 3 commits intomainfrom
vendor-config-401t

Conversation

@ThomasK33
Copy link
Member

@ThomasK33 ThomasK33 commented Feb 10, 2026

Summary

This PR hardens vendor workflow guidance and removes fragile stamp-file behavior that caused CI drift.

Background

Agent runs were deleting vendor stamp artifacts unexpectedly. The prior Makefile relied on vendor/.modules.stamp, which is not stable under go mod vendor and led to verify-vendor check failures.

Implementation

  • Updated Makefile to use vendor/modules.txt as the vendor freshness target marker:
    • VENDOR_STAMP := vendor/modules.txt
    • removed manual touch/directory creation for .modules.stamp
  • Removed obsolete .modules.stamp ignore handling from .gitignore
  • Updated AGENTS.md guidance to explicitly protect vendor/modules.txt and removed .modules.stamp references

Validation

  • make verify-vendor
  • make test
  • make build
  • make lint

Risks

Low. This aligns stamping with canonical go mod vendor output and reduces CI/local mismatch risk.


Generated with mux • Model: openai:gpt-5.3-codex • Thinking: xhigh • Cost: $0.23

@ThomasK33
Copy link
Member Author

@codex review

Please review this PR.

@ThomasK33
Copy link
Member Author

@codex review

Addressed CI feedback and updated the PR.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ThomasK33
Copy link
Member Author

@codex review

Updated per reviewer direction:

  • switched Makefile vendoring marker to vendor/modules.txt
  • removed .modules.stamp handling
  • aligned AGENTS guidance
    Please re-review.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ThomasK33 ThomasK33 added this pull request to the merge queue Feb 10, 2026
@ThomasK33
Copy link
Member Author

Merged via the queue into main with commit 4cc1631 Feb 10, 2026
7 checks passed
@ThomasK33 ThomasK33 deleted the vendor-config-401t branch February 10, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant