Skip to content

🤖 fix: document vendor stamp-file handling #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasK33 merged 3 commits into from
Feb 10, 2026
Merged

🤖 fix: document vendor stamp-file handling #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3478c02
🤖 docs: clarify vendor stamp-file handling
ThomasK33 Feb 10, 2026
7815278
🤖 fix: ignore generated vendor stamp file
ThomasK33 Feb 10, 2026
b502e5e
🤖 fix: use vendor/modules.txt as vendoring marker
ThomasK33 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ Run from repository root.
**Don’t** silently ignore these paths or convert them to soft failures.
- **Do** keep vendoring in sync when dependencies change (`go mod tidy`, `go mod vendor`, then verify diff).
**Don’t** submit dependency changes without updating `vendor/`.
**Don’t** manually delete or edit `vendor/modules.txt`; refresh vendoring via `go mod tidy && go mod vendor` (or `make vendor`) instead.
- **Do** regenerate generated artifacts after API changes (`make codegen`, `make manifests`).
**Don’t** hand-edit generated files like `zz_generated.deepcopy.go` or CRD/RBAC manifests.
- **Do** keep controller, aggregated API server, and storage changes paired with focused tests (`main_test.go`, `internal/controller/*_test.go`, and package tests under `internal/app/`/`internal/aggregated/`).
Expand Down
4 changes: 1 addition & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
GOFLAGS ?= -mod=vendor
VENDOR_STAMP := vendor/.modules.stamp
VENDOR_STAMP := vendor/modules.txt
MODULE_FILES := go.mod $(wildcard go.sum)
ENVTEST_K8S_VERSION ?= 1.35.x
ENVTEST_ASSETS_DIR := $(shell pwd)/bin/envtest
Expand All @@ -9,8 +9,6 @@ ENVTEST_ASSETS_DIR := $(shell pwd)/bin/envtest
$(VENDOR_STAMP): $(MODULE_FILES)
go mod tidy
go mod vendor
@mkdir -p $(dir $@)
@touch $@

vendor: $(VENDOR_STAMP)

Expand Down