Tweak image upload help text #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsmkn
reviewed
Jan 7, 2025
app/grandchallenge/cases/forms.py
Outdated
| "MIRAX (.mrxs), Ventana (.bif) and DICOM-WSI (.dcm)." | ||
| ) | ||
| IMAGE_UPLOAD_HELP_TEXT = """ | ||
| <p> |
There was a problem hiding this comment.
I do not like all of this extra whitespace. Now you have a bunch of floating statements in the form. Before, it was clear all statements belong to the widget, now, do some belong to the widget and some to the button below? Unclear. I would prefer just to keep to line breaks if necessary. I don't think that adding empty lines will mean that users will suddenly start reading the docs.
There was a problem hiding this comment.
Check! Reverted to the line breaks, screenshots updated.
jmsmkn
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user mentioned some confusion by clinicians trying to upload dicoms. Imho the user had a valid point. The help text also had the suggestion that .tiff was converted to MHA. That is incorrect. I opted to sacrifice some horizontal space for clarity.
Before
After
Note: text is used in a widget, no need for a migration.