Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak image upload help text #3774

Merged
merged 2 commits into from
Jan 7, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions app/grandchallenge/cases/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,26 @@
from grandchallenge.uploads.models import UserUpload
from grandchallenge.uploads.widgets import UserUploadMultipleWidget

IMAGE_UPLOAD_HELP_TEXT = (
"The total size of all files uploaded in a single session "
"cannot exceed 10 GB. "
"A maximum of 100 files can be uploaded per session. "
"Please only upload one volume per session. "
"If your volume consists of more than this then please compress the "
"directory and upload a single .zip file.<br>"
"The following file formats are supported and will be converted to MHA: "
".mha, .mhd, .raw, .zraw, .dcm, .nii, .nii.gz, .nrrd, "
".fda, .fds, .tiff, .png, .jpeg and .jpg.<br>"
"The following file formats can be uploaded and will be converted to "
"TIFF: Aperio (.svs), Hamamatsu (.vms, .vmu, .ndpi), Leica (.scn), "
"MIRAX (.mrxs), Ventana (.bif) and DICOM-WSI (.dcm)."
)
IMAGE_UPLOAD_HELP_TEXT = """
<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like all of this extra whitespace. Now you have a bunch of floating statements in the form. Before, it was clear all statements belong to the widget, now, do some belong to the widget and some to the button below? Unclear. I would prefer just to keep to line breaks if necessary. I don't think that adding empty lines will mean that users will suddenly start reading the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check! Reverted to the line breaks, screenshots updated.

The total size of all files uploaded in a single session cannot exceed 10 GB.
A maximum of 100 files can be uploaded per session.
</p>
<p>
Please only upload one volume per session. If your volume is made up of multiple
individual slices (e.g. DICOM files), please compress the entire directory into
a single .zip file and upload that file.
</p>
<p>
The following file formats are supported and will be converted to MHA format:
.mha, .mhd, .raw, .zraw, .dcm, .nii, .nii.gz, .nrrd, .fda, .fds, .png, .jpeg, and .jpg.
</p>
<p>
The following file formats can be uploaded and will be converted to TIF format:
.tiff, Aperio (.svs), Hamamatsu (.vms, .vmu, .ndpi), Leica (.scn), MIRAX (.mrxs),
Ventana (.bif), and DICOM-WSI (.dcm)."
</p>
"""


class UploadRawImagesForm(SaveFormInitMixin, forms.ModelForm):
Expand Down
Loading