Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecations #506

Merged
merged 1 commit into from
Oct 13, 2023
Merged

remove deprecations #506

merged 1 commit into from
Oct 13, 2023

Conversation

jenschude
Copy link
Contributor

  • Changeset added

Features

Fixes

Breaking changes

Removed deprecations:

  • methods in CtAsyncHttpClient
  • methods in RetryMiddleware
  • ApiFactory
  • ImportApiFactory
  • MLApiRootFactory
  • HistoryApiFactory
  • "rmf:okhttp-client: module
  • ClientFactory
  • MiddlewareFactory
  • ExceptionFactory
  • VrapJsonUtils

- methods in CtAsyncHttpClient
- methods in RetryMiddleware
- ApiFactory
- ImportApiFactory
- MLApiRootFactory
- HistoryApiFactory
- "rmf:okhttp-client: module
- ClientFactory
- MiddlewareFactory
- ExceptionFactory
- VrapJsonUtils
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (76f7e8d) 9.82% compared to head (76e8495) 9.88%.

❗ Current head 76e8495 differs from pull request most recent head 77dbb2c. Consider uploading reports for the commit 77dbb2c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main    #506      +/-   ##
==========================================
+ Coverage     9.82%   9.88%   +0.06%     
+ Complexity    1639    1634       -5     
==========================================
  Files         5823    5813      -10     
  Lines        56380   55889     -491     
  Branches       247     240       -7     
==========================================
- Hits          5538    5524      -14     
+ Misses       50700   50223     -477     
  Partials       142     142              
Files Coverage Δ
...ommercetools/http/asynchttp/CtAsyncHttpClient.java 12.30% <ø> (+2.66%) ⬆️
.../io/vrap/rmf/base/client/http/RetryMiddleware.java 27.39% <ø> (+4.06%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenschude jenschude merged commit a24e645 into main Oct 13, 2023
9 checks passed
@jenschude jenschude deleted the remove_deprecations branch October 13, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant