Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecations #506

Merged
merged 1 commit into from
Oct 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ def documentationProjects= [
":commercetools:commercetools-sdk-java-importapi",
":commercetools:commercetools-sdk-java-ml",
":commercetools:internal-docs",
":rmf:okhttp-client",
":rmf:rmf-java-base"
]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,6 @@ public CtAsyncHttpClient() {
clientBuilder.get().addRequestFilter(new ThrottleRequestFilter(MAX_REQUESTS)).build());
}

/**
* @deprecated usage of maxConnTotal and maxConnPerRoute not advised as there is no pooling done by AHC. Use {@link CtAsyncHttpClient#CtAsyncHttpClient(int)} instead.
* @param maxConnPerRoute maximum number of parallel connections to one host
* @param maxConnTotal maximum number of parallel connections
*/
@Deprecated
public CtAsyncHttpClient(final int maxConnTotal, final int maxConnPerRoute) {
super();
asyncHttpClient = new DefaultAsyncHttpClient(
clientBuilder.get().setMaxConnections(maxConnTotal).setMaxConnectionsPerHost(maxConnPerRoute).build());
}

/**
* Uses a {@link ThrottleRequestFilter} to limit the number of concurrent requests
* @param maxConnections maximum number of parallel connections
Expand All @@ -67,20 +55,6 @@ public CtAsyncHttpClient(final BuilderOptions options) {
asyncHttpClient = new DefaultAsyncHttpClient(options.plus(clientBuilder.get()).build());
}

/**
* @deprecated usage of maxConnTotal and maxConnPerRoute not advised as there is no pooling done by AHC. Use {@link CtAsyncHttpClient#CtAsyncHttpClient(int, BuilderOptions)} instead.
* @param maxConnPerRoute maximum number of parallel connections to one host
* @param maxConnTotal maximum number of parallel connections
* @param options options to build the underlying HTTP client
*/
@Deprecated
public CtAsyncHttpClient(final int maxConnTotal, final int maxConnPerRoute, final BuilderOptions options) {
super();
asyncHttpClient = new DefaultAsyncHttpClient(
options.plus(clientBuilder.get().setMaxConnections(maxConnTotal).setMaxConnectionsPerHost(maxConnPerRoute))
.build());
}

/**
* Uses a {@link ThrottleRequestFilter} to limit the number of concurrent requests
* @param maxConnections maximum number of parallel connections
Expand Down Expand Up @@ -110,19 +84,6 @@ public CtAsyncHttpClient(final ExecutorService executor) {
asyncHttpClient = new DefaultAsyncHttpClient(clientBuilder.get().build());
}

/**
* @deprecated usage of maxConnTotal and maxConnPerRoute not advised as there is no pooling done by AHC. Use {@link CtAsyncHttpClient#CtAsyncHttpClient(ExecutorService, int)} instead.
* @param maxConnPerRoute maximum number of parallel connections to one host
* @param maxConnTotal maximum number of parallel connections
* @param executor ExecutorService to be used
*/
@Deprecated
public CtAsyncHttpClient(final ExecutorService executor, final int maxConnTotal, final int maxConnPerRoute) {
super(executor);
asyncHttpClient = new DefaultAsyncHttpClient(
clientBuilder.get().setMaxConnections(maxConnTotal).setMaxConnectionsPerHost(maxConnPerRoute).build());
}

/**
* Uses a {@link ThrottleRequestFilter} to limit the number of concurrent requests
* @param maxConnections maximum number of parallel connections
Expand All @@ -144,22 +105,6 @@ public CtAsyncHttpClient(final ExecutorService executor, final BuilderOptions op
asyncHttpClient = new DefaultAsyncHttpClient(options.plus(clientBuilder.get()).build());
}

/**
* @deprecated usage of maxConnTotal and maxConnPerRoute not advised as there is no pooling done by AHC. Use {@link CtAsyncHttpClient#CtAsyncHttpClient(ExecutorService, int, BuilderOptions)} instead.
* @param maxConnPerRoute maximum number of parallel connections to one host
* @param maxConnTotal maximum number of parallel connections
* @param executor ExecutorService to be used
* @param options options to build the underlying HTTP client
*/
@Deprecated
public CtAsyncHttpClient(final ExecutorService executor, final int maxConnTotal, final int maxConnPerRoute,
final BuilderOptions options) {
super(executor);
asyncHttpClient = new DefaultAsyncHttpClient(
options.plus(clientBuilder.get().setMaxConnections(maxConnTotal).setMaxConnectionsPerHost(maxConnPerRoute))
.build());
}

/**
* Uses a {@link ThrottleRequestFilter} to limit the number of concurrent requests
* @param maxConnections maximum number of parallel connections
Expand Down

This file was deleted.

Loading
Loading