[Fix][DEVX-670] Fix Issues with Tools Configuration #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1a0be5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ajimae
requested review from
a team,
behnamt and
islam3zzat
and removed request for
behnamt
|
@ajimae can we make these configuration details explicit also in the readme file? |
islam3zzat
approved these changes
Nov 21, 2025
Contributor
islam3zzat
left a comment
islam3zzat
left a comment
There was a problem hiding this comment.
Thanks a lot, this has been an annoying bug
- fix issues with untrimmed configured tools - fix issues with configured tools not being obeyed when isAdmin is false. - refactor and adjust tests accordingly
Add release changeset for `patch` release.
- add and update info in README.md files
ajimae
force-pushed
the
fix/tool-configuration-and-issue-w-untrimmed-tools
branch
from
a91abcd to
1a0be5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issues with tools configuration and error due to untrimmed configured tools.
In this fix, we moved the
isAdmincheck up one layer from individual tools to the namespace list, this will help us to filter out configured tools efficiently and gives us the flexibility to make adjustments easily in the future. Also, the--tools=allargument now requires that--isAdminis set totrue.Completed Tasks
Related Issue
#39