Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX is_coplanar #1325

Merged
merged 2 commits into from
Apr 22, 2024
Merged

BUG FIX is_coplanar #1325

merged 2 commits into from
Apr 22, 2024

Conversation

petrasvestartas
Copy link
Contributor

@petrasvestartas petrasvestartas commented Apr 19, 2024

Little culprit, when there are 4 points, the while loop fails while popping points in predicates_3.py -> is_coplanar. The previous if statement in that method is not enough, which I guess was an initial assumption.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@tomvanmele
Copy link
Member

would be nice to add a test for the case that previously failed :)

@petrasvestartas
Copy link
Contributor Author

petrasvestartas commented Apr 20, 2024

@tomvanmele just added.

This method was used in compas_viewer hide_coplanar_edges. When you input meshes with extremely sharp faces, due to floating point errors they become almost co-linear. I added this IndexError test that pass through and should not cause issues.

Now it works, 3rd line from this screenshot:

Screenshot from 2024-04-20 12-26-19

@tomvanmele tomvanmele merged commit 5d89127 into compas-dev:main Apr 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants