Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG FIX is_coplanar #1325

Merged
merged 2 commits into from
Apr 22, 2024
Merged

BUG FIX is_coplanar #1325

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ade33cf
BUG FIX is_coplanar
petrasvestartas Apr 19, 2024
b9f60e1
ADD pytest test_core_predicates_3.py test_is_colplanar
petrasvestartas Apr 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Changed and updated the `compas_view2` examples into `compas_viewer`.
* Changed `compas.scene.Scene` to inherent from `compas.datastructrues.Tree`.
* Changed `compas.scene.SceneObject` to inherent from `compas.datastructrues.TreeNode`.
* Changed `compas.geoemetry._core.predicates_3` bug fix in `is_coplanar` while loop when there are 4 points.

### Removed

Expand Down
2 changes: 1 addition & 1 deletion src/compas/geometry/_core/predicates_3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def is_coplanar(points, tol=None):

temp = points[:]

while True:
while len(temp) >= 3:
a = temp.pop(0)
b = temp.pop(0)
c = temp.pop(0)
Expand Down
Loading