Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild maintenance branches for aws-sdk-cpp 1.9 & openssl 3? #918

Closed
Tracked by #3838
h-vetinari opened this issue Dec 9, 2022 · 7 comments
Closed
Tracked by #3838

Rebuild maintenance branches for aws-sdk-cpp 1.9 & openssl 3? #918

h-vetinari opened this issue Dec 9, 2022 · 7 comments

Comments

@h-vetinari
Copy link
Member

We released arrow v10 a couple of days ago built against aws-sdk-cpp 1.9, the first such build after a long time, since we were previously stuck on 1.8 due to aws/aws-sdk-cpp#1809

I've asked on all the related issues that I'm aware of if someone could test with v10 to see if the original issue persists or is gone (since we cannot test this on our infra).
#567
aws/aws-sdk-cpp#1809
https://issues.apache.org/jira/browse/ARROW-15141
huggingface/datasets#3310

I think after a certain time we can probably assume that things went fine (and IMO the fix is pretty unambiguous).

Assuming we can agree on this among @conda-forge/arrow-cpp, I'd like to backport this to the maintenance branches, because to continue with the OpenSSL 3 migration, we need aws-sdk-cpp 1.9. And not having OpenSSL 3 for arrow <10 is quite painful for libraries wanting to build against all arrow versions in the global pinning, c.f. conda-forge/gdal-feedstock#679

Thoughts?

@jakirkham
Copy link
Member

Applying the same migrations to the branches covered by ABI migrations makes sense. Maybe it is worth applying all migrations together?

@h-vetinari
Copy link
Member Author

Generally yes, I'd agree to merge migrations for all ABI branches. In this case it's more like a feature though to use aws-sdk-cpp 1.9 after it's been on 1.8 for the affected arrow versions for more than a year, all the more due to the potential for regressions.

I'd be much happier if I heard from anyone affected by the original issue on AWS to confirm it doesn't happen with arrow 10 anymore (the thinking was to only do one arrow version that bumps aws-sdk-cpp initially, so that marking things as broken is less painful, if it becomes necessary).

Applying both migrations together makes sense of course (though I dread how many restarts it will take to get a passing run on 8.0.x and 9.0.x after the build matrix doubles in size)

@h-vetinari
Copy link
Member Author

Confirmed to be fixed - thanks a lot @jdblischak! :)

@h-vetinari
Copy link
Member Author

h-vetinari commented Dec 10, 2022

Maybe it is worth applying all migrations together?

I have prepared the following PRs, which also backport some clean-ups from #875 (and making sure we enable all bindings/libs for that are available for the respective version):

The 8.0.x & 9.0.x PRs will need a gratuitous number of restarts (or we drop CUDA+aarch on those branches), but otherwise these should all be fine / ready.

@h-vetinari
Copy link
Member Author

@pitrou @xhochy
Would appreciate your thoughts on this :)

@xhochy
Copy link
Member

xhochy commented Dec 12, 2022

If it works, let's move forward and apply the migration to these branches! 🚀

@h-vetinari
Copy link
Member Author

All done now. 🤞 we get no regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants