Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sys.exit with CondaBuildUserError exceptions #5255

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Mar 25, 2024

Description

Resolves #4209
Resolves #5242

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 25, 2024
Copy link

codspeed-hq bot commented Mar 25, 2024

CodSpeed Performance Report

Merging #5255 will not alter performance

Comparing kenodegard:remove-sys.exit (d6f0312) with main (6b222c7)

Summary

✅ 3 untouched benchmarks

conda_build/exceptions.py Outdated Show resolved Hide resolved
This was referenced Mar 27, 2024
@kenodegard kenodegard changed the base branch from main to 24.5.x May 1, 2024 20:22
@kenodegard kenodegard force-pushed the remove-sys.exit branch 2 times, most recently from 697a07b to 1943a58 Compare May 20, 2024 21:00
beeankha added a commit to beeankha/conda-build that referenced this pull request Jun 25, 2024
beeankha added a commit that referenced this pull request Jul 8, 2024
* Update exceptions imports/usage in metadata.py

* Replace sys.exit call with CondaBuildUserError for select_lines() function

* Add unit test for CondaBuildUserError exception in select_lines test

* Replace sys.exit call in _git_clean() and add unit test

* Replace sys.exit call in check_bad_chrs() and add unit test

* Update import statements and remove sys.exit call from yamlize()

* Mark _get_env_path() for deprecation

* Remove sys.exit call from parse_until_resolved() and add unit test

* Remove sys.exit call from _get_contents()

* Ignore deprecation warnings in metadata.py tests, point to correct exception in test_jinja_typo in test_api_build.py

* Relax match string in error assertion for Windows

* Revert 'cleanup' code changes from #5255
@beeankha beeankha mentioned this pull request Jul 9, 2024
3 tasks
@kenodegard kenodegard changed the base branch from 24.5.x to main July 11, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace using sys.exit with higher level error/logic handling, e.g. custom exception Remove sys.exit calls
4 participants