Avoid undefined jinja errors for skipped recipes #5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
msarahan
force-pushed
the
exit-render-early-on-skip
branch
from
68f96ec
to
3275a7b
Compare
CodSpeed Performance ReportMerging #5458 will not alter performanceComparing Summary
|
|
Thanks Michael! 🙏 If it is helpful, here is a generic example ( conda-forge/conda-smithy#2011 ) |
This was referenced Aug 13, 2024
msarahan
force-pushed
the
exit-render-early-on-skip
branch
from
3275a7b
to
c509bbb
Compare
msarahan
force-pushed
the
exit-render-early-on-skip
branch
from
c509bbb
to
6f1c010
Compare
|
Thanks Michael! 🙏 Looks like this is passes Canary builds fail, but those are pointing out deprecations in other tests. Think we can safely ignore those here |
jakirkham
previously approved these changes
Aug 14, 2024
|
@kenodegard could you please take a look as well? 🙂 |
This was referenced Aug 14, 2024
beeankha
reviewed
Aug 22, 2024
|
The tests are blocked by conda/conda#14169 |
|
Thanks Bianca and Ken! 🙏 |
5 tasks
jaimergp
added a commit
to jaimergp/staged-recipes
that referenced
this pull request
Aug 29, 2024
jaimergp
added a commit
to conda-forge/staged-recipes
that referenced
this pull request
Aug 29, 2024
|
macOS tests are failing due to #5470 |
beeankha
approved these changes
Sep 4, 2024
kenodegard
approved these changes
Sep 4, 2024
|
Thanks for sticking with this through the slog, @beeankha and @kenodegard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few NVIDIA feedstocks on conda-forge have been failing to re-render lately. See conda-forge/cuda-nvdisasm-feedstock#12. The expected behavior was that undefined jinja variables shouldn't error out when the metadata is skipped.
I tracked it back to #5371, which I think is a good code improvement. In order to avoid these irrelevant errors for skipped recipes, we just abort after the first parsing pass.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?