-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateway 2.2.2 version #36
Conversation
Signed-off-by: ConduktorBot <automation@conduktor.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to update the chart version and the appVersion inside chart.yaml as well
fixed c7d2074 |
@@ -1,5 +1,5 @@ | |||
apiVersion: v2 | |||
appVersion: "2.2.1" | |||
appVersion: "2.2.2" | |||
description: Conduktor Gateway and associated backing Kafka | |||
name: conduktor-gateway | |||
version: 2.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: 2.2.2 | |
version: 2.2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appVersion
and version
are not in sync ? Is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR
version: 2.2.4
appVersion: "2.2.2"
"appVersion: The version of the app that this contains (optional). Needn't be SemVer. Quotes recommended." https://helm.sh/docs/topics/charts/#the-chartyaml-file
so we try to keep it in sync with image version used by the chart. In this case GW 2.2.2
And we increment the chart version
every time we make a change respecting semver spec strictly.
Also during the time this PR was on flight, an update to the chart was pushed and merged so now the current chart version of GW is 2.2.3
so your PR should update it to 2.2.4
We have a chart linter on CI/PR that enforce that rule but still be careful to not override an already released chart version.
2.3.0 is realease. |
No description provided.