Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway 2.2.2 version #36

Closed
wants to merge 3 commits into from
Closed

gateway 2.2.2 version #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7270591
gateway 2.2.2 version
framiere Nov 16, 2023
c706429
chore(chart): Update README.md with readme-generator-for-helm
ConduktorBot Nov 16, 2023
c7d2074
Update Chart.yaml
framiere Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/gateway/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v2
appVersion: "2.2.1"
appVersion: "2.2.2"
description: Conduktor Gateway and associated backing Kafka
name: conduktor-gateway
version: 2.2.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 2.2.2
version: 2.2.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appVersion and version are not in sync ? Is that expected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://conduktor-team.slack.com/archives/C04KW5ALNHJ/p1700232376989339

TL;DR needs fixing - https://linear.app/conduktor/issue/PXY-1279/have-helm-released-version-match-the-version-of-gw

Copy link
Member

@qboileau qboileau Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR

version: 2.2.4
appVersion: "2.2.2"

"appVersion: The version of the app that this contains (optional). Needn't be SemVer. Quotes recommended." https://helm.sh/docs/topics/charts/#the-chartyaml-file
so we try to keep it in sync with image version used by the chart. In this case GW 2.2.2
And we increment the chart version every time we make a change respecting semver spec strictly.

Also during the time this PR was on flight, an update to the chart was pushed and merged so now the current chart version of GW is 2.2.3 so your PR should update it to 2.2.4
We have a chart linter on CI/PR that enforce that rule but still be careful to not override an already released chart version.

Expand Down
2 changes: 1 addition & 1 deletion charts/gateway/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ This section define the image to be used
| --------------------------- | ---------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `gateway.image.registry` | Docker registry to use | `docker.io` |
| `gateway.image.repository` | Image in repository format (conduktor/conduktor-gateway) | `conduktor/conduktor-gateway` |
| `gateway.image.tag` | Image tag | `2.1.0` |
| `gateway.image.tag` | Image tag | `2.2.2` |
| `gateway.image.pullPolicy` | Kubernetes image pull policy | `IfNotPresent` |
| `gateway.replicas` | number of gateway instances to be deployed | `2` |
| `gateway.secretRef` | Secret name to load sensitive env var from | `""` |
Expand Down
2 changes: 1 addition & 1 deletion charts/gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ gateway:
## @param gateway.image.repository Image in repository format (conduktor/conduktor-gateway)
repository: conduktor/conduktor-gateway
## @param gateway.image.tag Image tag
tag: 2.1.0
tag: 2.2.2
## @param gateway.image.pullPolicy Kubernetes image pull policy
pullPolicy: IfNotPresent

Expand Down
Loading