-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a to_any helper in the containerd client crate #363
Conversation
ping @mxpv - not sure what is going on with CI; looks like an error in the shim package tests, but not sure how it could be related to my change? |
Thanks! Fixed that, but looks like many CI jobs are having the same output about a type definition in the shim, with a recommended fix (but I have no idea if that's a change somewhere in the CI underpinning platform that caused that or a weird by-product of my change?):
|
Not sure how to debug CI here; Taking a simple job like “Timings” and running it locally (even with my PR change), I can’t reproduce the error. How are Rust versions managed in GH Actions; any chance something changed? Here is my output:
|
Ya, there is something weird going on with |
This provides a solution to Any->type matching that happens on the containerd Go-based server side where the Any types in prost use typeurl as defined in the protobuf spec and the server side is matching on the fullname property of the type. Signed-off-by: Phil Estes <estesp@amazon.com>
Looks like we are good now! Thanks |
Fixes: #362
This provides a solution to Any->type matching that happens on the containerd Go-based server side where the Any types in prost use typeurl as defined in the protobuf spec and the server side is matching on the fullname property of the type.