OCI image-spec / distribution-spec v1.1 updates, first round #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
oci-1.1-little
branch
2 times, most recently
from
3cfb544
to
5a70811
Compare
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... so update one of our checks to rely on the specified status (only). Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... as now requested by distribution-spec. Untested apart from the added parser unit test. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
As described in the comment, this might cause excess noise. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... to reduce duplication. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... so that newOCI1ImageSource can support other configs. Should not change (test) behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change (test) behavior for now. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This is a MUST requirement from OCI image spec v1.1. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Zero-layer artifacts are discouraged but allowed. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an assorted set of small changes to support OCI image-spec/distribution-spec 1.1.
Follow #2030 for checklists of things to update/address.
See individual commit messages for details. Note especially the RFC and UNTESTED ones.