Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCI image-spec / distribution-spec v1.1 updates, first round #2062

Merged
merged 13 commits into from
Aug 10, 2023
Merged

OCI image-spec / distribution-spec v1.1 updates, first round #2062

merged 13 commits into from
Aug 10, 2023

Commits on Aug 10, 2023

  1. Add a comment about mounting blobs with unknown locations 

    Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6fb4da1 View commit details
    Browse the repository at this point in the history

  2. opencontainers/distribution-spec does not require errors to carry JSON 

    ... so update one of our checks to rely on the specified status (only).

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    62f49ac View commit details
    Browse the repository at this point in the history

  3. UNTESTED: Log warnings on a Warning: header 

    ... as now requested by distribution-spec.

Untested apart from the added parser unit test.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    91536ef View commit details
    Browse the repository at this point in the history

  4. Add a comment about using the os.version and os.flags fields. 

    Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    8a2fca6 View commit details
    Browse the repository at this point in the history

  5. RFC: Match variant in checkImageDestinationForCurrentRuntime 

    As described in the comment, this might cause excess noise.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3a26748 View commit details
    Browse the repository at this point in the history

  6. Avoid a nil pointer dereference in EditInstances 

    Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    98a9280 View commit details
    Browse the repository at this point in the history

  7. Define helpers for cloning and conversion of platform descriptors 

    ... to reduce duplication.

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d4733ea View commit details
    Browse the repository at this point in the history

  8. Avoid some single-use variables 

    Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7daea33 View commit details
    Browse the repository at this point in the history

  9. Support the new ArtifactType field when complaining about non-images 

    Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9ee0a99 View commit details
    Browse the repository at this point in the history

  10. Don't hard-code a single digest in configBlobImageSource 

    ... so that newOCI1ImageSource can support other configs.

Should not change (test) behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9495679 View commit details
    Browse the repository at this point in the history

  11. Allow specifying the config fixture in newOCI1ImageSource 

    Should not change (test) behavior for now.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9c3d98d View commit details
    Browse the repository at this point in the history

  12. Add tests to ensure that extra fields in config.json are not rejected. 

    This is a MUST requirement from OCI image spec v1.1.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6e8a5a7 View commit details
    Browse the repository at this point in the history

  13. Fix a possible division by zero 

    Zero-layer artifacts are discouraged but allowed.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5253f01 View commit details
    Browse the repository at this point in the history