Introduce boxed types for margins and handling of input #4402
YaraslautAnnotations
7 warnings
|
triage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/labeler@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
clang-tidy:
src/vtbackend/Terminal_test.cpp#L402
warning: avoid do-while loops [cppcoreguidelines-avoid-do-while]
```cpp
REQUIRE(appHandledMouse == Handled{false});
^
```
<details>
<summary>Additional context</summary>
**_deps/sources/Catch2-3.4.0/src/catch2/catch_test_macros.hpp:124:** expanded from macro 'REQUIRE'
```cpp
#define REQUIRE( ... ) INTERNAL_CATCH_TEST( "REQUIRE", Catch::ResultDisposition::Normal, __VA_ARGS__ )
^
```
**_deps/sources/Catch2-3.4.0/src/catch2/internal/catch_test_macro_impl.hpp:44:** expanded from macro 'INTERNAL_CATCH_TEST'
```cpp
do { /* NOLINT(bugprone-infinite-loop) */ \
^
```
</details>
|
|
clang-tidy:
src/vtbackend/ViInputHandler.cpp#L426
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
Handled ViInputHandler::handleSearchEditor(char32_t ch, Modifiers modifiers)
^
```
|
|
clang-tidy:
src/vtbackend/ViInputHandler.cpp#L473
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
Handled ViInputHandler::sendCharPressEvent(char32_t ch, Modifiers modifiers)
^
```
|
|
clang-tidy:
src/vtbackend/ViInputHandler.h#L191
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
Handled sendCharPressEvent(char32_t ch, Modifiers modifiers) override;
^
```
|
|
clang-tidy:
src/vtbackend/ViInputHandler.h#L239
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
Handled handleSearchEditor(char32_t ch, Modifiers modifiers);
^
```
|
|
clang-tidy:
src/vtbackend/ViInputHandler.h#L240
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
Handled handleModeSwitches(char32_t ch, Modifiers modifiers);
^
```
|