Skip to content

Introduce boxed types for margins and handling of input #4402

Introduce boxed types for margins and handling of input

Introduce boxed types for margins and handling of input #4402

GitHub Actions / clang-tidy-review completed Mar 26, 2024 in 0s

clang-tidy-review

There were 6 warnings

Details

src/vtbackend/Terminal_test.cpp:402: warning: avoid do-while loops [cppcoreguidelines-avoid-do-while]
src/vtbackend/ViInputHandler.cpp:426: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/ViInputHandler.cpp:473: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/ViInputHandler.h:191: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/ViInputHandler.h:239: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/ViInputHandler.h:240: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]

Annotations

Check warning on line 402 in src/vtbackend/Terminal_test.cpp

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: avoid do-while loops [cppcoreguidelines-avoid-do-while]
```cpp
    REQUIRE(appHandledMouse == Handled{false});
    ^
```
<details>
<summary>Additional context</summary>

**_deps/sources/Catch2-3.4.0/src/catch2/catch_test_macros.hpp:124:** expanded from macro 'REQUIRE'
```cpp
  #define REQUIRE( ... ) INTERNAL_CATCH_TEST( "REQUIRE", Catch::ResultDisposition::Normal, __VA_ARGS__  )
                         ^
```
**_deps/sources/Catch2-3.4.0/src/catch2/internal/catch_test_macro_impl.hpp:44:** expanded from macro 'INTERNAL_CATCH_TEST'
```cpp
    do { /* NOLINT(bugprone-infinite-loop) */ \
    ^
```

</details>

Check warning on line 426 in src/vtbackend/ViInputHandler.cpp

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
Handled ViInputHandler::handleSearchEditor(char32_t ch, Modifiers modifiers)
                                                    ^
```

Check warning on line 473 in src/vtbackend/ViInputHandler.cpp

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
Handled ViInputHandler::sendCharPressEvent(char32_t ch, Modifiers modifiers)
                                                    ^
```

Check warning on line 191 in src/vtbackend/ViInputHandler.h

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
    Handled sendCharPressEvent(char32_t ch, Modifiers modifiers) override;
                                        ^
```

Check warning on line 239 in src/vtbackend/ViInputHandler.h

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
    Handled handleSearchEditor(char32_t ch, Modifiers modifiers);
                                        ^
```

Check warning on line 240 in src/vtbackend/ViInputHandler.h

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
    Handled handleModeSwitches(char32_t ch, Modifiers modifiers);
                                        ^
```