Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DSA method of redress configurable #4398

Merged
merged 7 commits into from
Nov 20, 2023

Conversation

nick-funk
Copy link
Contributor

@nick-funk nick-funk commented Nov 16, 2023

What does this PR do?

  • Makes the DSA method of redress configurable under Admin > Config > General > DSA.
  • Shows method of redress under the notifications tab stream side.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

Adds the configurable MethodOfRedress type to the DSAConfig.

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

No new indices.

How do I test this PR?

  • If you previously enabled DSA, you need to modify your tenant with the following
    • The old format of:
       "dsa": {
         "enabled": true,
         "methodOfRedress": "NONE"
       },
      
    • Needs to be changed to:
      "dsa": {
       "enabled": true,
       "methodOfRedress": {
         "method": "NONE",
       }
      },
      
  • Go to Admin > Config > General > DSA, enable DSA, and select a method of redress
    • Select and fill in fields for URL or Email if you choose them, see that they validate for a proper URL/email
  • Head to notifications tab stream side
  • See that there is a light blue method of redress callout above your notification items

Where any tests migrated to React Testing Library?

No

How do we deploy this PR?

No special considerations.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 1f35832
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65567cda0275ec00086b113f

@nick-funk nick-funk requested review from marcushaddon and kabeaty and removed request for marcushaddon November 16, 2023 20:37
@nick-funk nick-funk changed the base branch from develop to feat/dsa-launch-pad November 16, 2023 20:37
@nick-funk nick-funk marked this pull request as ready for review November 16, 2023 20:42
@nick-funk nick-funk changed the title Add DSA method of redress to the Admin > Config Add DSA method of redress Nov 16, 2023
@nick-funk nick-funk changed the title Add DSA method of redress Make DSA method of redress configurable Nov 16, 2023
@nick-funk nick-funk mentioned this pull request Nov 16, 2023
4 tasks
Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

url: settings.dsa.methodOfRedress.url,
}}
>
{`To appeal a decision that appears here please visit ${settings.dsa.methodOfRedress.url}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, should the email and url here be links that are actionable? Or we just expect folks to copy and paste into their browser/email?

@nick-funk nick-funk merged commit 6bb79de into feat/dsa-launch-pad Nov 20, 2023
@nick-funk nick-funk deleted the feat/DSA-config-method-of-redress branch November 20, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants