-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improves e2e test, adds mod files for standalone run #822
Conversation
Do you mind rebasing this PR @M4tteoP ? |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 81.57% 81.98% +0.41%
==========================================
Files 158 156 -2
Lines 8959 8711 -248
==========================================
- Hits 7308 7142 -166
+ Misses 1406 1339 -67
+ Partials 245 230 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rsc.io/binaryregexp v0.2.0 // indirect | ||
) | ||
|
||
replace github.com/corazawaf/coraza/v3/http/e2e => ../../http/e2e/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add it because actually the /coraza/v3/http/e2e/runner
package is not just inside the remote coraza/v3.
What is strange is that, removing the replace and updating coraza to v3.0.2 inside this submodule it ends up with ambiguous import: found package github.com/corazawaf/coraza/v3/testing/e2e in multiple modules
Superseded by #841, thanks @jcchavezs 🙇♂️ |
Work in progress:
The following command is now running:
But
go mod tidy
run undertesting/e2e/
submodule is failing, even if the test itself is working: