Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes e2e pkg. #841

Merged
merged 9 commits into from
Jul 11, 2023
Merged

chore: fixes e2e pkg. #841

merged 9 commits into from
Jul 11, 2023

Conversation

jcchavezs
Copy link
Member

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Make sure that you've checked the boxes below before you submit PR:

Thanks for your contribution ❤️

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (cc4ec80) 81.57% compared to head (f0fdcbf) 81.60%.

❗ Current head f0fdcbf differs from pull request most recent head 2a6ee5a. Consider uploading reports for the commit 2a6ee5a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   81.57%   81.60%   +0.03%     
==========================================
  Files         158      158              
  Lines        8959     8958       -1     
==========================================
+ Hits         7308     7310       +2     
+ Misses       1406     1404       -2     
+ Partials      245      244       -1     
Flag Coverage Δ
default 76.60% <100.00%> (+0.03%) ⬆️
examples 25.66% <ø> (ø)
ftw 47.11% <ø> (ø)
ftw-multiphase 49.25% <ø> (ø)
tinygo 72.71% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
http/e2e/cmd/httpe2e/main.go 0.00% <ø> (ø)
http/e2e/e2e.go 73.68% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@M4tteoP M4tteoP marked this pull request as ready for review July 8, 2023 22:09
@M4tteoP M4tteoP requested a review from a team as a code owner July 8, 2023 22:09
@jcchavezs
Copy link
Member Author

Superseed #822

@jcchavezs jcchavezs merged commit e20a5b4 into main Jul 11, 2023
7 checks passed
@jcchavezs jcchavezs deleted the fixes_e2e_pkg branch July 11, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants