flatcar/v1_2_exp: Add clevis support #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pothos
reviewed
Apr 2, 2024
config/flatcar/v1_2_exp/translate.go
Outdated
| // Return FieldFilters for this spec. | ||
| func (c Config) FieldFilters() *cutil.FieldFilters { | ||
| return &fieldFilters | ||
| return &cutil.FieldFilters{} |
There was a problem hiding this comment.
Suggested change
| return &cutil.FieldFilters{} | |
| return nil |
Thanks for the PR! The only thing I would see is that the other translate.go files use nil here
There was a problem hiding this comment.
Changed it to nil here. (This also required a tiny change to the test logic, handling the case of FieldFilters() returning nil.)
simoncampion
force-pushed
the
add-clevis-flatcar
branch
from
ed4e2cf
to
c8b2584
Compare
prestist
reviewed
Apr 8, 2024
simoncampion
force-pushed
the
add-clevis-flatcar
branch
from
c8b2584
to
a8c311b
Compare
|
@prestist Thanks! I added an entry in the release notes and ran |
prestist
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
flatcar/v1_2_expto reflect Flatcar can handle disk encryption with clevis, since this commit.