Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the styling issue in Students page etc #535

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Fixing the styling issue in Students page etc #535

merged 2 commits into from
Oct 5, 2024

Conversation

Atikpui007
Copy link
Collaborator

Summary

This pull request is a fix for the styling issues brought up in #507

  • Removed the general styling of the select,date and time inputs to use ID based styling.

Test Plan

Looked at the web page and it styles as expected

Notes

Breaking Changes

@Atikpui007 Atikpui007 requested a review from a team as a code owner October 5, 2024 15:42
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 20.

namanhboi
namanhboi approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@namanhboi namanhboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Styling is now fixed on the Students and Analytics page. I'll work on the styling of the Add Edit Student Modal now

@Atikpui007 Atikpui007 merged commit 661966e into master Oct 5, 2024
5 checks passed
@Atikpui007 Atikpui007 deleted the dka34/Select-Styling-Fix branch October 5, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namanhboi namanhboi namanhboi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Atikpui007 @dti-github-bot @namanhboi