Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the styling issue in Students page etc #535

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Fixing the styling issue in Students page etc #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b04ea9
Fixing the styling issue in Students page etc
Atikpui007 Oct 5, 2024
60067ef
Prettier Fix again :/
Atikpui007 Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/src/components/RideModal/Pages/RideTimes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ const RideTimesPage: React.FC<RideTimesProps> = ({
},
})}
aria-required="true"
className={cn(styles.dateStyle)}
/>
{errors.date?.type === 'required' && (
<p className={styles.error}>Please enter a date</p>
Expand All @@ -211,6 +212,7 @@ const RideTimesPage: React.FC<RideTimesProps> = ({
{...register('repeats', {
required: 'Please select a repeat option',
})}
className={cn(styles.selectInputContainer, styles.selectInput)}
>
{repeatOptions.map((option) => (
<option key={option.id} value={option.id}>
Expand All @@ -228,6 +230,7 @@ const RideTimesPage: React.FC<RideTimesProps> = ({
<Input
id="pickupTime"
type="time"
className={cn(styles.timeStyle)}
{...register('pickupTime', {
required: true,
validate: (pickupTime: string) => {
Expand All @@ -250,6 +253,7 @@ const RideTimesPage: React.FC<RideTimesProps> = ({
<Input
id="dropoffTime"
type="time"
className={cn(styles.timeStyle)}
{...register('dropoffTime', {
required: true,
validate: (dropoffTime: string) => {
Expand Down
16 changes: 4 additions & 12 deletions frontend/src/components/RideModal/ridemodal.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
}

/* Input styles */
input[type='date'],
input[type='time'],
select {
.dateStyle,
.timeStyle,
.selectInputContainer {
width: 100%;
padding: 0.75rem;
font-size: 1rem;
Expand All @@ -37,16 +37,8 @@ select {
transition: border-color 0.15s ease-in-out, box-shadow 0.15s ease-in-out;
}

input[type='date']:focus,
input[type='time']:focus,
select:focus {
outline: none;
border-color: #80bdff;
box-shadow: 0 0 0 0.2rem rgba(0, 123, 255, 0.25);
}

/* Styled select */
select {
.selectInput {
appearance: none;
-webkit-appearance: none;
-moz-appearance: none;
Expand Down
Loading