Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build for both linux/amd64 and linux/arm64 #30

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Build for both linux/amd64 and linux/arm64 #30

merged 1 commit into from
Sep 21, 2024

Conversation

maxslarsson
Copy link
Contributor

@maxslarsson maxslarsson commented Sep 19, 2024 •
edited
Loading

Fixes #32

@ZachGarcia42 ZachGarcia42 mentioned this pull request Sep 19, 2024
Merged
@maxslarsson Graphite App
Copy link
Contributor Author

maxslarsson commented Sep 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maxslarsson and the rest of your teammates on Graphite Graphite

@maxslarsson maxslarsson mentioned this pull request Sep 19, 2024
Merged
@maxslarsson maxslarsson marked this pull request as ready for review September 19, 2024 00:39
@maxslarsson maxslarsson force-pushed the 09-18-build_for_both_linux_amd64_and_linux_arm64 branch from 7c00654 to 4c70b88 Compare September 19, 2024 00:46
ZachGarcia42
ZachGarcia42 reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ZachGarcia42 ZachGarcia42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Want to see passing status checks, and can you try running the image on a raspi 4 and confirm it works there? Just leave a comment on this PR when that's confirmed (maybe a picture too?)

@maxslarsson maxslarsson force-pushed the 09-18-add_docker_caching branch 2 times, most recently from 3f3e486 to a06fe03 Compare September 19, 2024 04:10
@maxslarsson maxslarsson force-pushed the 09-18-build_for_both_linux_amd64_and_linux_arm64 branch from 4c70b88 to 5d7baf7 Compare September 19, 2024 04:10
Base automatically changed from 09-18-add_docker_caching to main September 19, 2024 05:04
@maxslarsson maxslarsson force-pushed the 09-18-build_for_both_linux_amd64_and_linux_arm64 branch from 5d7baf7 to ad11c8c Compare September 19, 2024 05:07
@maxslarsson maxslarsson mentioned this pull request Sep 19, 2024
Merged
ZachGarcia42
ZachGarcia42 approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@ZachGarcia42 ZachGarcia42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran on Pi 4 Successfully

@ZachGarcia42 Graphite App
Copy link
Contributor

ZachGarcia42 commented Sep 21, 2024 •
edited
Loading

Merge activity

@ZachGarcia42 ZachGarcia42 merged commit 5d3f2e3 into main Sep 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZachGarcia42 ZachGarcia42 ZachGarcia42 approved these changes

@cameron-goddard cameron-goddard Awaiting requested review from cameron-goddard cameron-goddard is a code owner

@nragland nragland Awaiting requested review from nragland nragland is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Docker for both amd64 and arm64
2 participants
@maxslarsson @ZachGarcia42